Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Introduce nav tags #6540

Merged
merged 4 commits into from
Mar 9, 2022
Merged

[full-ci] Introduce nav tags #6540

merged 4 commits into from
Mar 9, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Mar 7, 2022

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Mar 7, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear requested a review from JammingBen March 7, 2022 13:36
@ownclouders
Copy link
Contributor

Results for oc10SharingIntUsers3 https://drone.owncloud.com/owncloud/web/23356/31/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L59.png

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L59.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@pascalwengerter pascalwengerter changed the title Introduce nav tags [full-ci] Introduce nav tags Mar 7, 2022
@@ -10,8 +10,11 @@
:data-nav-id="index"
:data-nav-name="navName"
>
<oc-icon :name="icon" :fill-type="fillType" />
<span class="oc-ml-m text" :class="{ 'text-invisible': collapsed }" v-text="name" />
<span class="oc-flex">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just rebased to get CI green but then figured this small change here perhaps breaks selectors in the acceptance tests. I'll fix them locally and then push to the branch

@ownclouders
Copy link
Contributor

Results for oc10SharingIntUsers3 https://drone.owncloud.com/owncloud/web/23381/31/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L59.png

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L59.png

@ownclouders
Copy link
Contributor

Results for oC10Resharing https://drone.owncloud.com/owncloud/web/23381/22/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIResharing1-reshareUsers_feature-L230.png

webUIResharing1-reshareUsers_feature-L230.png

@ownclouders
Copy link
Contributor

Results for oC10SharingIntUsers2 https://drone.owncloud.com/owncloud/web/23381/30/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalUsersToRootShareWithPage-shareWithUsers_feature-L52.png

webUISharingInternalUsersToRootShareWithPage-shareWithUsers_feature-L52.png

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23381/69/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUITrashbinRestore-trashbinRestore_feature-L222.png

webUITrashbinRestore-trashbinRestore_feature-L222.png

webUITrashbinRestore-trashbinRestore_feature-L241.png

webUITrashbinRestore-trashbinRestore_feature-L241.png

@ownclouders
Copy link
Contributor

Results for oC10SharingAndTrashbin https://drone.owncloud.com/owncloud/web/23381/33/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUITrashbinRestore-trashbinRestore_feature-L222.png

webUITrashbinRestore-trashbinRestore_feature-L222.png

webUITrashbinRestore-trashbinRestore_feature-L241.png

webUITrashbinRestore-trashbinRestore_feature-L241.png

@ownclouders
Copy link
Contributor

Results for oC10Files4 https://drone.owncloud.com/owncloud/web/23381/19/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFilesDetails-fileDetails_feature-L142.png

webUIFilesDetails-fileDetails_feature-L142.png

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/23381/68/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicManagement-shareByPublicLink_feature-L12.png

webUISharingPublicManagement-shareByPublicLink_feature-L12.png

webUISharingPublicManagement-shareByPublicLink_feature-L170.png

webUISharingPublicManagement-shareByPublicLink_feature-L170.png

@ownclouders
Copy link
Contributor

Results for oC10Sharing2 https://drone.owncloud.com/owncloud/web/23381/24/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIResharingToRoot-reshareUsers_feature-L228.png

webUIResharingToRoot-reshareUsers_feature-L228.png

@ownclouders
Copy link
Contributor

Results for oCISFiles2 https://drone.owncloud.com/owncloud/web/23381/56/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFilesDetails-fileDetails_feature-L142.png

webUIFilesDetails-fileDetails_feature-L142.png

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal3 https://drone.owncloud.com/owncloud/web/23381/61/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L59.png

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L59.png

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23381/67/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkCreate_feature-L88.png

webUISharingPublicBasic-publicLinkCreate_feature-L88.png

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/23381/16/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFavorites-favoritesFile_feature-L65.png

webUIFavorites-favoritesFile_feature-L65.png

webUIFavorites-favoritesFile_feature-L74.png

webUIFavorites-favoritesFile_feature-L74.png

webUIFavorites-favoritesFile_feature-L81.png

webUIFavorites-favoritesFile_feature-L81.png

@ownclouders
Copy link
Contributor

Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/23381/36/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkCreate_feature-L88.png

webUISharingPublicBasic-publicLinkCreate_feature-L88.png

@ownclouders
Copy link
Contributor

Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/23381/37/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicManagement-shareByPublicLink_feature-L12.png

webUISharingPublicManagement-shareByPublicLink_feature-L12.png

webUISharingPublicManagement-shareByPublicLink_feature-L134.png

webUISharingPublicManagement-shareByPublicLink_feature-L134.png

webUISharingPublicManagement-shareByPublicLink_feature-L170.png

webUISharingPublicManagement-shareByPublicLink_feature-L170.png

@ownclouders
Copy link
Contributor

Results for oc10SharingIntUsers3 https://drone.owncloud.com/owncloud/web/23385/31/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L59.png

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L59.png

@ownclouders
Copy link
Contributor

Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/23399/36/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkEdit_feature-L101.png

webUISharingPublicBasic-publicLinkEdit_feature-L101.png

webUISharingPublicBasic-publicLinkEdit_feature-L115.png

webUISharingPublicBasic-publicLinkEdit_feature-L115.png

webUISharingPublicBasic-publicLinkEdit_feature-L207.png

webUISharingPublicBasic-publicLinkEdit_feature-L207.png

webUISharingPublicBasic-publicLinkPublicActions_feature-L18.png

webUISharingPublicBasic-publicLinkPublicActions_feature-L18.png

@ownclouders
Copy link
Contributor

Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/23399/37/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L114.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L114.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L149.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L149.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L181.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L181.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L221.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L221.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L257.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L257.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L266.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L266.png

webUISharingPublicManagement-shareByPublicLink_feature-L19.png

webUISharingPublicManagement-shareByPublicLink_feature-L19.png

webUISharingPublicManagement-sharingPublicSession_feature-L10.png

webUISharingPublicManagement-sharingPublicSession_feature-L10.png

webUISharingPublicManagement-sharingPublicSession_feature-L20.png

webUISharingPublicManagement-sharingPublicSession_feature-L20.png

webUISharingPublicManagement-sharingPublicSession_feature-L28.png

webUISharingPublicManagement-sharingPublicSession_feature-L28.png

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

@@ -231,6 +231,8 @@ function getMountedWrapper(spaceResources = [], spaceItem = null, imageContent =
$client: {
files: {
getFileContents: jest.fn().mockImplementation(() => Promise.resolve('filecontent')),
// TODO: Add & reference space fixtures in line below
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janackermann there's some test warnings about not being able to access the fileInfo in the view. I think it'd make a lot of sense to add spaces fixtures and import them here

@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23406/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23406/tracing/alice-shares-file-to-brian-alice-2022-3-8-04-21-59.zip

@ownclouders
Copy link
Contributor

Results for oC10Upload https://drone.owncloud.com/owncloud/web/23407/38/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIUpload-upload_feature-L173.png

webUIUpload-upload_feature-L173.png

@ownclouders
Copy link
Contributor

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/23407/66/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIUpload-upload_feature-L173.png

webUIUpload-upload_feature-L173.png

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23407/67/1
The following scenarios passed on retry:

  • webUISharingPublicBasic/publicLinkPublicActions.feature:44
💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkEdit_feature-L101.png

webUISharingPublicBasic-publicLinkEdit_feature-L101.png

webUISharingPublicBasic-publicLinkEdit_feature-L115.png

webUISharingPublicBasic-publicLinkEdit_feature-L115.png

webUISharingPublicBasic-publicLinkEdit_feature-L207.png

webUISharingPublicBasic-publicLinkEdit_feature-L207.png

webUISharingPublicBasic-publicLinkPublicActions_feature-L18.png

webUISharingPublicBasic-publicLinkPublicActions_feature-L18.png

@ownclouders
Copy link
Contributor

Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/23407/36/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkEdit_feature-L101.png

webUISharingPublicBasic-publicLinkEdit_feature-L101.png

webUISharingPublicBasic-publicLinkEdit_feature-L115.png

webUISharingPublicBasic-publicLinkEdit_feature-L115.png

webUISharingPublicBasic-publicLinkEdit_feature-L207.png

webUISharingPublicBasic-publicLinkEdit_feature-L207.png

webUISharingPublicBasic-publicLinkPublicActions_feature-L18.png

webUISharingPublicBasic-publicLinkPublicActions_feature-L18.png

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/23407/68/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L114.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L114.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L149.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L149.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L181.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L181.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L221.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L221.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L257.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L257.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L266.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L266.png

webUISharingPublicManagement-shareByPublicLink_feature-L19.png

webUISharingPublicManagement-shareByPublicLink_feature-L19.png

webUISharingPublicManagement-sharingPublicSession_feature-L10.png

webUISharingPublicManagement-sharingPublicSession_feature-L10.png

webUISharingPublicManagement-sharingPublicSession_feature-L20.png

webUISharingPublicManagement-sharingPublicSession_feature-L20.png

webUISharingPublicManagement-sharingPublicSession_feature-L28.png

webUISharingPublicManagement-sharingPublicSession_feature-L28.png

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

@ownclouders
Copy link
Contributor

Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/23407/37/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L114.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L114.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L149.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L149.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L181.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L181.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L221.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L221.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L257.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L257.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L266.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L266.png

webUISharingPublicManagement-shareByPublicLink_feature-L19.png

webUISharingPublicManagement-shareByPublicLink_feature-L19.png

webUISharingPublicManagement-sharingPublicSession_feature-L10.png

webUISharingPublicManagement-sharingPublicSession_feature-L10.png

webUISharingPublicManagement-sharingPublicSession_feature-L20.png

webUISharingPublicManagement-sharingPublicSession_feature-L20.png

webUISharingPublicManagement-sharingPublicSession_feature-L28.png

webUISharingPublicManagement-sharingPublicSession_feature-L28.png

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

@ownclouders
Copy link
Contributor

Results for oC10Upload https://drone.owncloud.com/owncloud/web/23412/38/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIUpload-upload_feature-L173.png

webUIUpload-upload_feature-L173.png

@ownclouders
Copy link
Contributor

Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/23412/36/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkEdit_feature-L101.png

webUISharingPublicBasic-publicLinkEdit_feature-L101.png

webUISharingPublicBasic-publicLinkEdit_feature-L115.png

webUISharingPublicBasic-publicLinkEdit_feature-L115.png

webUISharingPublicBasic-publicLinkEdit_feature-L207.png

webUISharingPublicBasic-publicLinkEdit_feature-L207.png

webUISharingPublicBasic-publicLinkPublicActions_feature-L18.png

webUISharingPublicBasic-publicLinkPublicActions_feature-L18.png

@ownclouders
Copy link
Contributor

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/23412/66/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIUpload-upload_feature-L173.png

webUIUpload-upload_feature-L173.png

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23412/67/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkEdit_feature-L101.png

webUISharingPublicBasic-publicLinkEdit_feature-L101.png

webUISharingPublicBasic-publicLinkEdit_feature-L115.png

webUISharingPublicBasic-publicLinkEdit_feature-L115.png

webUISharingPublicBasic-publicLinkEdit_feature-L207.png

webUISharingPublicBasic-publicLinkEdit_feature-L207.png

webUISharingPublicBasic-publicLinkPublicActions_feature-L18.png

webUISharingPublicBasic-publicLinkPublicActions_feature-L18.png

@ownclouders
Copy link
Contributor

Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/23412/37/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L114.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L114.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L149.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L149.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L181.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L181.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L221.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L221.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L257.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L257.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L266.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L266.png

webUISharingPublicManagement-shareByPublicLink_feature-L19.png

webUISharingPublicManagement-shareByPublicLink_feature-L19.png

webUISharingPublicManagement-sharingPublicSession_feature-L10.png

webUISharingPublicManagement-sharingPublicSession_feature-L10.png

webUISharingPublicManagement-sharingPublicSession_feature-L20.png

webUISharingPublicManagement-sharingPublicSession_feature-L20.png

webUISharingPublicManagement-sharingPublicSession_feature-L28.png

webUISharingPublicManagement-sharingPublicSession_feature-L28.png

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/23412/68/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L114.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L114.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L149.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L149.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L181.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L181.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L221.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L221.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L257.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L257.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L266.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L266.png

webUISharingPublicManagement-shareByPublicLink_feature-L19.png

webUISharingPublicManagement-shareByPublicLink_feature-L19.png

webUISharingPublicManagement-sharingPublicSession_feature-L10.png

webUISharingPublicManagement-sharingPublicSession_feature-L10.png

webUISharingPublicManagement-sharingPublicSession_feature-L20.png

webUISharingPublicManagement-sharingPublicSession_feature-L20.png

webUISharingPublicManagement-sharingPublicSession_feature-L28.png

webUISharingPublicManagement-sharingPublicSession_feature-L28.png

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L35.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

webUISharingPublicManagement-sharingPublicSession_feature-L48.png

@pascalwengerter
Copy link
Contributor

pascalwengerter commented Mar 9, 2022

Merging #6548 turned quite a bunch of tests green, the remaining ones seem to resolve around tests that run as "the public accesses public link XY" but since the current user never logged out (topbar with avatar stays visible) fail with the screenshot below

Screenshot 2022-03-09 at 11 56 31

Sadly, I couldn't find anything in either console nor backend logs

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23431/67/1
The following scenarios passed on retry:

  • webUISharingPublicBasic/publicLinkCreate.feature:190

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23431/69/1
The following scenarios passed on retry:

  • webUITrashbinRestore/trashbinRestore.feature:279

JanAckermann and others added 4 commits March 9, 2022 12:52
remove padding

Adjust tag height

Add changelog item

lowercase beta tag

Change bg color for tag

Update snapshots

Adjustments according to PR review

Update changelog/unreleased/enhancement-sidebar-nav-tags

Co-authored-by: Jannik Stehle <[email protected]>

Fix linter

Use the new size property of oc-tag
Update snapshots

Add ODS bump changelog item

Fix sidebarnav acceptance test selectors

Lint fix

Rebase, fix snapshots && test warnings

Fix snapshots after rebase
…on type in ODS (#6548)

Co-authored-by: Pascal Wengerter <[email protected]>

Fix snapshot test
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23440/67/1
The following scenarios passed on retry:

  • webUISharingPublicBasic/publicLinkPublicActions.feature:44

@pascalwengerter pascalwengerter merged commit 3f3340c into master Mar 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the nav-tags branch March 9, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

badges for nav-items
6 participants